fix: Improve dynamic adjustment of prompt input height#4582
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4582 +/- ##
==========================================
+ Coverage 97.43% 97.45% +0.01%
==========================================
Files 941 942 +1
Lines 29692 29716 +24
Branches 10792 10800 +8
==========================================
+ Hits 28930 28959 +29
+ Misses 715 710 -5
Partials 47 47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
amanabiy
reviewed
Jun 5, 2026
| * @param elementRef - A ref object pointing to the element to observe. | ||
| * @param onWidthChange - Callback fired when the element's width changes. | ||
| */ | ||
| export function useWidthChange(elementRef: React.RefObject<HTMLElement>, onWidthChange: () => void): void { |
Member
There was a problem hiding this comment.
Is it possible to use useResizeObserver instead of useWidthChange?
Member
Author
There was a problem hiding this comment.
Extended the comment text to explain the difference:
Unlike useResizeObserver from the component-toolkit package, it does not cause re-renders when the width changes.
amanabiy
approved these changes
Jun 5, 2026
NathanZlion
pushed a commit
that referenced
this pull request
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the input height not only on window resize, but also when the component itself changes width for whatever reason (for example, by expanding or collapsing drawers). Otherwise the prompt input height will become stale in these cases.
Issue:
AWSUI-62050How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.